Hi Linus, On Wed, 2019-01-30 at 09:16 +0100, Linus Walleij wrote: > On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > > > Since the TVE provides a clock to the DI, the driver can only be > > compiled if the common clock framework is enabled. With the COMMON_CLK > > dependency in place, it will be possible to allow building the other > > parts of imx-drm under COMPILE_TEST on architectures that do not select > > the common clock framework. > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > Since the clock framework has stubs I bet it can be *compiled* without > COMMON_CLK. But it will certainly not work so if you reword the commit: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> thank you for the review. It indeed does not compile because struct imx_tve embeds a struct clk_hw, which is defined in linux/clk-provider.h only if COMMON_CLK is enabled. regards Philipp _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
