On Tue, 2019-01-22 at 10:16 +0100, Uwe Kleine-König wrote: > On Tue, Jan 22, 2019 at 05:02:43PM +0800, Jitao Shi wrote: > > Use the mtk_pwm_data struction to define different registers > > and add MT8183 specific register operations, such as MT8183 > > doesn't have commit register, needs to disable double buffer > > before writing register, and needs to select commit mode > > and use PWM_PERIOD/PWM_HIGH_WIDTH. > > > > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx> > > There is no difference compared to (implicit) v1 sent a few minutes > earlier, right? There was another patch sent with the same Subject last > week, so I assume the mail from today without "v2" in the Subject was a > mistake? > > > --- > Adding a paragraph below the tripple dash that points out what was > changed compared to the previous submission is a good idea to help > reviewers to more easily see what was changed. I guess you only adapted > the commit log as a reaction to Matthias Burgger's review? > > Best regards > Uwe > Yes, I miss the "V2" and fine tune the commit message. Best Regards Jitao _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
