Re: [PATCH v1 1/1] drm: fix drm_can_sleep() comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 20, 2019 at 06:12:17PM +0100, Sam Ravnborg wrote:
> Reversed logic when writing the original comment, now fixed.
> 
> Fixes: e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h")
> Reported-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> Cc: Sean Paul <sean@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>

Thanks, merged.
-Daniel

> ---
>  include/drm/drm_util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h
> index 8163d35f8327..07b8e9f04599 100644
> --- a/include/drm/drm_util.h
> +++ b/include/drm/drm_util.h
> @@ -71,7 +71,7 @@
>   * FIXME: All users of drm_can_sleep should be removed (see todo.rst)
>   *
>   * Returns:
> - * True if kgdb is active or we are in an atomic context or irqs are disabled
> + * False if kgdb is active, we are in atomic context or irqs are disabled.
>   */
>  static inline bool drm_can_sleep(void)
>  {
> -- 
> 2.12.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux