Hi Laurent, Thank you for you comments. On 03/22/2012 12:24 PM, Laurent Pinchart wrote: > Hi Tomasz, > > Thanks for the patch. > > On Tuesday 13 March 2012 11:17:03 Tomasz Stanislawski wrote: >> This patch adds extension to videobuf2-core. It allow to export a mmap >> buffer as a file descriptor. >> >> Signed-off-by: Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> >> --- >> drivers/media/video/videobuf2-core.c | 64 >> ++++++++++++++++++++++++++++++++++ include/media/videobuf2-core.h | >> 2 + >> 2 files changed, 66 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/media/video/videobuf2-core.c >> b/drivers/media/video/videobuf2-core.c index e7df560..41c4bf8 100644 >> --- a/drivers/media/video/videobuf2-core.c >> +++ b/drivers/media/video/videobuf2-core.c >> @@ -1553,6 +1553,70 @@ int vb2_dqbuf(struct vb2_queue *q, struct v4l2_buffer >> *b, bool nonblocking) } >> EXPORT_SYMBOL_GPL(vb2_dqbuf); >> >> +static int __find_plane_by_offset(struct vb2_queue *q, unsigned long off, >> + unsigned int *_buffer, unsigned int *_plane); >> + > > Could you please move __find_plane_by_offset() up or move vb2_expbuf() down to > avoid the forward declaration ? The later might make more sense, you could > declare vb2_expbuf() right after vb2_mmap() (here and in videobuf2-core.h), > both functions perform similar tasks. > Ok. I will move it. I used the forward declaration to have only-plus patch while keeping all vb2_*buf functions together. Regards, Tomasz Stanislawski _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
