Re: [PATCH v8] drm/panel: Add a driver for the TPO TPG110

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 11, 2019 at 11:24 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> The TPO (Toppoly) TPG110 is a pretty generic display driver
> similar in vein to the Ilitek 93xx devices. It is not a panel
> per se but a driver used with several low-cost noname panels.
>
> This is used on the Nomadik NHK15 combined with a OSD
> OSD057VA01CT display for WVGA 800x480.
>
> The driver is pretty minimalistic right now but can be
> extended to handle non-default polarities, gamma correction
> etc.
>
> The driver is based on the baked-in code in
> drivers/video/fbdev/amba-clcd-nomadik.c which will be
> decomissioned once this us upstream.
>
> Cc: Noralf Trønnes <noralf@xxxxxxxxxxx>
> Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v7->v8:
> - Lifecycle the backlight properly with devm_of_find_backlight()
> - Drop if (backlight) clauses since helper are NULL-tolerant
> ChangeLog v6->v7:
> - Drop the video mode helpers.
> - Do not include <drm/drmP.h> but instead the granular APIs.
> - Switch dev_info() and dev_err() for DRM_DEV_INFO()
>   and DRM_DEV_ERROR().
> - Switch mdelay(1) for usleep_range(1000,2000) so we don't
>   spin unecessarily during boot.
> - Use DRM_DEV_DEBUG() for information about deasserted reset.
> - Make a proper DRM_DEV_ERROR() for illegal resolution settings.
> - Simplify the inlined backlight enable/disable code by using
>   the existing inline helpers.
> - Add a few missing stray \n's
> ChangeLog v5->v6:
> - Collected Sam's ACK.
> ChangeLog v4->v5:
> - Assign proper bus_flags.
> - This is now the only remaining patch.
> ChangeLog v3->v4:
> - Tag on the SPI_3WIRE_HIZ flag to the SPI slave mode.
> ChangeLog v2->v3:
> - Rewrite as an SPI child device.
> ---
>  MAINTAINERS                              |   7 +
>  drivers/gpu/drm/panel/Kconfig            |   9 +
>  drivers/gpu/drm/panel/Makefile           |   1 +
>  drivers/gpu/drm/panel/panel-tpo-tpg110.c | 496 +++++++++++++++++++++++
>  4 files changed, 513 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-tpo-tpg110.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 32d444476a90..e177473d5417 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4909,6 +4909,13 @@ DRM DRIVER FOR TDFX VIDEO CARDS
>  S:     Orphan / Obsolete
>  F:     drivers/gpu/drm/tdfx/
>
> +DRM DRIVER FOR TPO TPG110 PANELS
> +M:     Linus Walleij <linus.walleij@xxxxxxxxxx>
> +T:     git git://anongit.freedesktop.org/drm/drm-misc
> +S:     Maintained
> +F:     drivers/gpu/drm/panel/panel-tpo-tpg110.c
> +F:     Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt

Except my query about this change in v6, all look fine on this driver.

Acked-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux