On Thu, 10 Jan 2019 15:10:39 +0000 Peter Rosin <peda@xxxxxxxxxx> wrote: > The destination crtc rectangle is independent of source plane rotation. > > Signed-off-by: Peter Rosin <peda@xxxxxxxxxx> > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index ea8fc0deb814..d6f93f029020 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -642,9 +642,6 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p, > * Swap width and size in case of 90 or 270 degrees rotation > */ > if (drm_rotation_90_or_270(state->base.rotation)) { > - tmp = state->crtc_w; > - state->crtc_w = state->crtc_h; > - state->crtc_h = tmp; Again, I guess I assumed ->crtc_h/w were the width and height before rotation when I initially added rotation support. This change might break users too. > tmp = state->src_w; > state->src_w = state->src_h; > state->src_h = tmp; _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel