Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sam,

On 2/1/19 22:37, Sam Ravnborg wrote:
> The problem with the RED/BLUE lines swapped is something I
> have encountered while working with DRM support for Atmel at91sam9263 too.
> 
> The solution selected is to extend the endpoint with
> a new optional property:
> 
> - wiring: Wiring of data lines to display.
>   "straight" - normal wiring.
>   "red-blue-reversed" - red and blue lines reversed.
> 
> (media/video-interfaces.txt)
> 
> 
> The DT node looks like this:
> 
>                port@0 {
>                         reg = <0>;
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         lcdc_panel_output: endpoint@0 {
>                                 reg = <0>;
>                                 wiring = "red-blue-reversed";
>                                 remote-endpoint = <&panel_input>;
>                         };
>                 };
> 
> This allows us to specify the swapping in the endpoint and
> not in the panel.
> So we can use the same panel, with the same bus_format, in several
> designs some with red-blue swapped (reversed), and some not.

A colleague suggested a property in the endpoint as well, but I shied
away because of the extra hassle. Seems there's won't be a way around it ^^'..

How do you intend to propagate this different wiring setting?
How about having drm_of_find_panel_or_bridge adjust the
(*panel)->connector->display_info.bus_formats array to account for the
different wiring? That way there shouldn't be any need to adjust drivers.

> 
> This above is inspired by some earlier thread on dri-devel.
> I recall Peter Rosin was one of the main source of inspiration.

Thanks for the interesting read.

> 
> Patches I refer to are not yet posted, this is work-in-progess.
> They need more polishing and testing before they are dri-devel ready

Cheers
Ahmad

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux