On Thu, Jan 03, 2019 at 12:16:46AM -0800, Christoph Hellwig wrote: > On Sun, Dec 30, 2018 at 06:48:31PM +0100, Sam Ravnborg wrote: > > +/* > > + * Use EXPORT_SYMBOL_FOR_TESTS_ONLY() for functions that shall > > + * only be visible for drmselftests. > > + */ > > +#if defined(CONFIG_DRM_DEBUG_SELFTEST_MODULE) > > +#define EXPORT_SYMBOL_FOR_TESTS_ONLY(x) EXPORT_SYMBOL(x) > > +#else > > +#define EXPORT_SYMBOL_FOR_TESTS_ONLY(x) > > +#endif > > Btw, why isn't this an EXPORT_SYMBOL_GPL if it is only for internal > tests? Yeah EXPORT_SYMBOL_GPL makes sense here I think. Well most of drm is still MIT, so it's a bit hm, but the semantics of _GPL still seem like what we. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
