Re: [PATCH] qcom-scm: Include <linux/err.h> header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



FYI, I already had a patch fixing this error (it is in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/include/linux/qcom_scm.h). This one is probably better though.

On 12/28/2018 02:31 PM, Bjorn Andersson wrote:
On Wed 26 Dec 04:06 PST 2018, Fabio Estevam wrote:

Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
the DRM_MSM symbol can be selected by SOC_IMX5 causing the following
error when building imx_v6_v7_defconfig:

In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
   return -ENODEV;

Include the <linux/err.h> header file to fix this problem.


Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Andy, please pick up for inclusion in -rc

Fabio, please use get_maintainers, so your patches hits the appropriate
mailing lists (linux-arm-msm@ in this case)

Regards,
Bjorn

Reported-by: kernelci.org bot <bot@xxxxxxxxxxxx>
Fixes: e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
---
  include/linux/qcom_scm.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
index 06996ad4f2bc..ce5a476fd733 100644
--- a/include/linux/qcom_scm.h
+++ b/include/linux/qcom_scm.h
@@ -13,6 +13,7 @@
  #ifndef __QCOM_SCM_H
  #define __QCOM_SCM_H
+#include <linux/err.h>
  #include <linux/types.h>
  #include <linux/cpumask.h>
--
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux