On Thu, Dec 27, 2018 at 06:27:53PM +0200, Jani Nikula wrote: > On Thu, 27 Dec 2018, Daniel Vetter <daniel@xxxxxxxx> wrote: > > I guess next up would be to split up i915_drv.h and intel_drv.h and see > > how much our driver is a spaghetti mess where everything needs everything > > else :-) > > In general this got me wondering how self-contained the header files > really need to be. Turns out even <linux/kernel.h> isn't self-contained, > it fails on do_div() for my config if <asm/div64.h> isn't included some > other route. Didn't dig deep, but by the looks of it this is not a new > breakage (if you can call it that). In a reasonable project I'd urge you to send the fix, but given my last endevaour into touching linux/kernel.h I can't really recommend that :-/ -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
