On 2018-12-19 10:12, Andrzej Hajda wrote: > On 19.12.2018 00:19, Peter Rosin wrote: >> Add optional property to specify a power-down GPIO. >> The pwdn-gpios name is already in use by the thine,thc63lvdm83d >> binding, so go with that. >> >> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt >> index f9e7dd666f58..47941d39f92f 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt >> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt >> @@ -31,6 +31,9 @@ Required properties: >> device-specific version corresponding to the device first >> followed by the generic version. >> >> +Optional properties: >> +- pwdn-gpios: Power-down control GPIO >> + > > > Since naming is not enforced by any datasheet I would propose something > more popular with less twisted logic. Maybe: > > - enable-gpios: ... (active high). That was my original thought too, but the driver implementing the lvds-encoder bindings also handles the mentioned thine,thc63lvdm83d lvds encoder, and that binding has the "pwdn" naming. So, for driver implementation simplicity I went with what was already there, thus allowing adding support for both bindings with one implementation (in patch 3/3). Adding code just to handle multiple names for the same thing does not sounds too appealing. Cheers, Peter _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
