On Wed, Dec 19, 2018 at 04:24:40PM +0100, Daniel Vetter wrote:
> On Wed, Dec 19, 2018 at 04:33:01PM +0200, Ville Syrjälä wrote:
> > On Wed, Dec 19, 2018 at 01:42:41PM +0000, emersion wrote:
> > > I guess DRM_MODE_FLAG_PIC_AR_MASK has been overlooked.
> >
> > Nope. We don't hang on to the aspect ratio flags internally
> > and they get wiped before we check against DRM_MODE_FLAG_ALL.
> > Not sure this makes any sense really, but that's how it is atm.
>
> Aspect ratio is disabled because the uapi didn't work out, SNA blew up.
It was fixed by the client cap.
>
> No one bothered to respin afaik. So yeah, nacked, needs to be fixed
> properly.
>
> A git blame should have brought that up too.
> -Daniel
>
> >
> > >
> > > Signed-off-by: Simon Ser <contact@xxxxxxxxxxx>
> > > ---
> > > include/uapi/drm/drm_mode.h | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> > > index d3e0fe31efc..b8d5226c8e5 100644
> > > --- a/include/uapi/drm/drm_mode.h
> > > +++ b/include/uapi/drm/drm_mode.h
> > > @@ -128,7 +128,8 @@ extern "C" {
> > > DRM_MODE_FLAG_HSKEW | \
> > > DRM_MODE_FLAG_DBLCLK | \
> > > DRM_MODE_FLAG_CLKDIV2 | \
> > > - DRM_MODE_FLAG_3D_MASK)
> > > + DRM_MODE_FLAG_3D_MASK | \
> > > + DRM_MODE_FLAG_PIC_AR_MASK)
> > >
> > > /* DPMS flags */
> > > /* bit compatible with the xorg definitions. */
> > > --
> > > 2.20.1
> > >
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> > --
> > Ville Syrjälä
> > Intel
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
