Following the documentation of the Legacy Backlight Brightness (LBB) Register in the configuration space of some Intel PCI graphics adapters, setting the LBB register with the value 0x0 causes the backlight to be turned off, and 0xFF causes the backlight to be set to 100% intensity (http://download.intel.com/embedded/processors/Whitepaper/324567.pdf). The Acer Aspire 5734Z, however, turns the backlight off at 0xFF and sets it to maximum intensity at 0. In consequence, the screen of this systems becomes dark at an early boot stage which makes it unusable. The same inversion applies to the BLC_PWM_CTL I915 register. This problem was introduced in kernel version 2.6.38 when the PCI device of this system was first supported by the i915 KMS module. This patch adds a quirk to invert the sense of the brightness variable in case an Acer Aspire 5734Z is encountered. Signed-off-by: Carsten Emde <C.Emde@xxxxxxxxx> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++++ drivers/gpu/drm/i915/intel_panel.c | 10 ++++++++++ 3 files changed, 23 insertions(+) Index: linux-3.3-rc7/drivers/gpu/drm/i915/i915_drv.h =================================================================== --- linux-3.3-rc7.orig/drivers/gpu/drm/i915/i915_drv.h +++ linux-3.3-rc7/drivers/gpu/drm/i915/i915_drv.h @@ -275,6 +275,7 @@ enum intel_pch { #define QUIRK_PIPEA_FORCE (1<<0) #define QUIRK_LVDS_SSC_DISABLE (1<<1) +#define QUIRK_BRIGHTNESS_INVERTED (1<<2) struct intel_fbdev; struct intel_fbc_work; Index: linux-3.3-rc7/drivers/gpu/drm/i915/intel_display.c =================================================================== --- linux-3.3-rc7.orig/drivers/gpu/drm/i915/intel_display.c +++ linux-3.3-rc7/drivers/gpu/drm/i915/intel_display.c @@ -8950,6 +8950,15 @@ static void quirk_ssc_force_disable(stru dev_priv->quirks |= QUIRK_LVDS_SSC_DISABLE; } +/* + * At least one machine (Acer Aspire 5734Z) has inverted backlight brightness + */ +static void quirk_brightness_inverted(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev->dev_private; + dev_priv->quirks |= QUIRK_BRIGHTNESS_INVERTED; +} + struct intel_quirk { int device; int subsystem_vendor; @@ -8984,6 +8993,9 @@ struct intel_quirk intel_quirks[] = { /* Sony Vaio Y cannot use SSC on LVDS */ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable }, + + /* Acer Aspire 5734Z has inverted backlight brightness */ + { 0x2a42, 0x1025, 0x0459, quirk_brightness_inverted }, }; static void intel_init_quirks(struct drm_device *dev) Index: linux-3.3-rc7/drivers/gpu/drm/i915/intel_panel.c =================================================================== --- linux-3.3-rc7.orig/drivers/gpu/drm/i915/intel_panel.c +++ linux-3.3-rc7/drivers/gpu/drm/i915/intel_panel.c @@ -28,6 +28,7 @@ * Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> */ +#include <linux/moduleparam.h> #include "intel_drv.h" #define PCI_LBPC 0xf4 /* legacy/combination backlight modes */ @@ -212,6 +213,10 @@ u32 intel_panel_get_backlight(struct drm } DRM_DEBUG_DRIVER("get backlight PWM = %d\n", val); + if (dev_priv->quirks & QUIRK_BRIGHTNESS_INVERTED) { + u32 max = intel_panel_get_max_backlight(dev); + val = max - val; + } return val; } @@ -229,6 +234,11 @@ static void intel_panel_actually_set_bac DRM_DEBUG_DRIVER("set backlight PWM = %d\n", level); + if (dev_priv->quirks & QUIRK_BRIGHTNESS_INVERTED) { + u32 max = intel_panel_get_max_backlight(dev); + level = max - level; + } + if (HAS_PCH_SPLIT(dev)) return intel_pch_panel_set_backlight(dev, level); _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
