On Thu, 2018-12-06 at 17:39 +0800, Zhang, Jerry(Junwei) wrote: > On 12/6/18 5:33 PM, Koenig, Christian wrote: > > Am 06.12.18 um 10:09 schrieb Michel Dänzer: > > > On 2018-12-06 3:43 a.m., Zhang, Jerry(Junwei) wrote: > > > > On 12/6/18 12:56 AM, Michel Dänzer wrote: > > > > > From: Michel Dänzer <michel.daenzer@xxxxxxx> > > > > > > > > > > All the output is related, so it should all be printed the same way. > > > > > Some of it was using pr_debug, but some of it appeared in dmesg by > > > > > default. The caller should handle failure, so there's no need to spam > > > > > dmesg with potentially quite a lot of output by default. > > > > > > > > > > Signed-off-by: Michel Dänzer <michel.daenzer@xxxxxxx> > > > > Sounds reasonable, but personally prefer to show error when some > > > > vital incident happens, e.g. no memory on eviction. > > > The amdgpu driver still prints these in that case: > > > > > > [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* amdgpu_cs_list_validate(validated) failed. > > > [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Not enough memory for command submission! Aren't dump_stack()s already done on all these allocation failures? I don't notice any use of __GFP_NOWARN on generic allocations in drm. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
