> > On Thu, Dec 06, 2018 at 05:59:25AM -0500, Frediano Ziglio wrote: > > > > > > Just use qxl_num_crtc directly everywhere instead of using > > > qdev->monitors_config->max_allowed. Drops pointless indirection > > > and also is less confusing. > > > > > > > To me is MORE confusing, why comparing number of something with > > another number? Previously code was comparing number of monitors > > with number of monitors, not number of CRTs with number of > > monitors. > > Yes, spice/qxl and drm/kms use slightly different terminology. > > drm crtc == qxl monitor. > drm framebuffer == qxl surface. > > You need to know that anyway when looking at the qxl ksm code. We > have function names like qxl_crtc_update_monitors_config(). I fail > to see why that is a problem ... > > cheers, > Gerd > > I don't see any problem too but you are explaining to me why your rationale "and also is less confusing" does not stand. Frediano _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
