Am 06.12.18 um 10:39 schrieb Zhang, Jerry(Junwei):
On 12/6/18 5:33 PM, Koenig, Christian wrote:
Am 06.12.18 um 10:09 schrieb Michel Dänzer:
On 2018-12-06 3:43 a.m., Zhang, Jerry(Junwei) wrote:
On 12/6/18 12:56 AM, Michel Dänzer wrote:
From: Michel Dänzer <michel.daenzer@xxxxxxx>
All the output is related, so it should all be printed the same way.
Some of it was using pr_debug, but some of it appeared in dmesg by
default. The caller should handle failure, so there's no need to spam
dmesg with potentially quite a lot of output by default.
Signed-off-by: Michel Dänzer <michel.daenzer@xxxxxxx>
Sounds reasonable, but personally prefer to show error when some
vital incident happens, e.g. no memory on eviction.
The amdgpu driver still prints these in that case:
[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR*
amdgpu_cs_list_validate(validated) failed.
[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Not enough memory for
command submission!
That's from cs submit, perhaps it may come from other places by
ttm_bo_evict_mm().
Is that right? Christian.
Yeah, exactly my thinking as well. When we silence the TTM messages we
might miss those cases.
Additional to that other drivers using TTM might not have those messages
either.
If TTM is to noisy we should use ratelimit and/or reduce the number and
size of the warning messages.
A simple "Warning, I ran out of memory during eviction!" should do.
Regards,
Christian.
Regards,
Jerry
That's plenty as far as I'm concerned. :)
Yeah, but in this case I would rather make the amdgpu messages debug
level and leave the TTM meassages on error level.
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
