The field is only used in a safety check during device connection/disconnection, where the src field can be easily used instead. Remove it and use src. Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> --- drivers/gpu/drm/omapdrm/dss/base.c | 6 ++---- drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/base.c b/drivers/gpu/drm/omapdrm/dss/base.c index 61a231d2fef3..8454e505b282 100644 --- a/drivers/gpu/drm/omapdrm/dss/base.c +++ b/drivers/gpu/drm/omapdrm/dss/base.c @@ -210,9 +210,8 @@ int omapdss_device_connect(struct dss_device *dss, } if (src) { - WARN_ON(src->dst); + WARN_ON(dst->src); dst->src = src; - src->dst = dst; } return 0; @@ -230,11 +229,10 @@ void omapdss_device_disconnect(struct omap_dss_device *src, } if (src) { - if (WARN_ON(dst != src->dst)) + if (WARN_ON(dst->src != src)) return; dst->src = NULL; - src->dst = NULL; } WARN_ON(dst->state != OMAP_DSS_DISPLAY_DISABLED); diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index 4c0980999576..28e24d65f211 100644 --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h @@ -411,7 +411,6 @@ struct omap_dss_device { struct dss_device *dss; struct omap_dss_device *src; - struct omap_dss_device *dst; struct omap_dss_device *next; struct list_head list; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel