There is no checks at all in this best_hole() ... can you review the patch again ? /Monk -----Original Message----- From: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Sent: Friday, November 23, 2018 5:34 PM To: Liu, Monk <Monk.Liu@xxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx Subject: RE: FW: [PATCH] drm: should break if already get the best size Quoting Liu, Monk (2018-11-23 09:11:02) > What do you mean the first in the chain ? and also can you explain the > " perfect match." ? thanks > > Assume there is couple nodes equal to the size you requested, without > this patch it will traveler to the bottom level of the RB tree and > gives you the node that close to the bottom level, which takes more > time compared with break on the first node, but anyway you eventually > get the node with the same size Size is but of one many checks the node must pass before being returned. -Chris _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel