>-----Original Message----- >From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] >Sent: Tuesday, November 20, 2018 7:41 PM >To: Shankar, Uma <uma.shankar@xxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; >intel-gfx@xxxxxxxxxxxxxxxxxxxxx >Cc: Syrjala, Ville <ville.syrjala@xxxxxxxxx>; jonas@xxxxxxxxx; >hansverk@xxxxxxxxx; Shankar, Uma <uma.shankar@xxxxxxxxx>; Lankhorst, >Maarten <maarten.lankhorst@xxxxxxxxx> >Subject: Re: [v3 2/3] drm: Add DP colorspace property > >Quoting Uma Shankar (2018-11-20 14:22:10) >> @@ -1457,6 +1480,18 @@ int drm_mode_create_colorspace_property(struct >drm_connector *connector) >> return -ENOMEM; >> >> dev->mode_config.hdmi_colorspace_property = prop; >> + } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP >|| >> + connector->connector_type == >DRM_MODE_CONNECTOR_DisplayPort) { >> + if (dev->mode_config.dp_colorspace_property) >> + return 0; >> + >> + prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM, >> + "DP_Colorspace", dp_colorspace, >> + ARRAY_SIZE(dp_colorspace)); >> + if (!prop) >> + return -ENOMEM; > >Why different names for DP/HDMI? There are some colorspaces specific to HDMI and DP, hence we created separate properties for these encoders. This is just to expose DP specifc colorspaces on a DP connector and same way for HDMI. Earlier, we had just one but it was giving DP stuff as well to a HDMI Connector and vice-versa which was not looking good. Regards, Uma Shankar >-Chris _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
