Hi Daniel, On Tue, Mar 6, 2012 at 12:27 AM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > On Fri, Mar 2, 2012 at 23:24, Rob Clark <robdclark@xxxxxxxxx> wrote: >> Perhaps we should check somewhere for required dmabuf ops fxns (like >> kmap_atomic here), rather than just calling unconditionally what might >> be a null ptr. At least put it in the WARN_ON(), but it might be >> nicer to catch a missing required fxns at export time, rather than >> waiting for an importer to try and call it. Less likely that way, for >> newly added required functions go unnoticed. >> >> (same comment applies below for the non-atomic variant.. and possibly >> some other existing dmabuf ops) > > Agreed, I'll rework the patch to do that when rebasing onto Sumit's latest tree. In addition, you'd not need to check for !dmabuf->ops since the export should already catch it. As I sent in the other mail a while back, could you please rebase on for-next at git://git.linaro.org/people/sumitsemwal/linux-dma-buf.git Best regards, ~Sumit. > -Daniel > -- _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
