* Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [181107 05:30]: > Hi Tony, > > Thank you for the patch. > > On Tuesday, 6 November 2018 17:28:02 EET Tony Lindgren wrote: > > We're missing a call to of_platform_depopulate() on errors for dsi. > > Looks like dss is already doing this. > > > > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > > This makes sense to me. You may however want to note in the commit message > that this patch also turns the of_platform_populate() failures into fatal > errors. Well of_platform_populate() failure should be fatal here,right? :) Tomi, let me know if you need a resend with updated comments or if you want to update the message yourself to your liking. Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel