Re: [RESEND PATCH] drm/etnaviv: Replace drm_dev_unref with drm_dev_put

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 07.11.18 um 17:37 schrieb Lucas Stach:
> Am Mittwoch, den 26.09.2018, 13:41 +0200 schrieb Thomas Zimmermann:
>> This patch unifies the naming of DRM functions for reference counting
>> of struct drm_device. The resulting code is more aligned with the rest
>> of the Linux kernel interfaces.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> 
> Thanks, now applied after slipping through the cracks a second time.

Great, thanks a lot.

> 
> Regards,
> Lucas
> 
>> ---
>>  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> index 9b2720b41571..9c204200757e 100644
>> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
>> @@ -523,7 +523,7 @@ static int etnaviv_bind(struct device *dev)
>>>  	if (!priv) {
>>>  		dev_err(dev, "failed to allocate private data\n");
>>>  		ret = -ENOMEM;
>>> -		goto out_unref;
>>> +		goto out_put;
>>>  	}
>>>  	drm->dev_private = priv;
>>
>> @@ -549,8 +549,8 @@ static int etnaviv_bind(struct device *dev)
>>>  	component_unbind_all(dev, drm);
>>  out_bind:
>>>  	kfree(priv);
>> -out_unref:
>>> -	drm_dev_unref(drm);
>> +out_put:
>>> +	drm_dev_put(drm);
>>
>>>  	return ret;
>>  }
>> @@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev)
>>>  	drm->dev_private = NULL;
>>>  	kfree(priv);
>>
>>> -	drm_dev_unref(drm);
>>> +	drm_dev_put(drm);
>>  }
>>
>>  static const struct component_master_ops etnaviv_master_ops = {
>> --
>> 2.19.0
>>

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755;  https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux