On Tue, 30 Oct 2018 at 13:52, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > > On Tue, Oct 30, 2018 at 11:31:04AM +0000, Emil Velikov wrote: > > HI Gerd, > > > > On Tue, 30 Oct 2018 at 06:11, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: > > > > > > Hi, > > > > > > > The execbuffer IOCTL is now read-write to allow the userspace to read the > > > > out-fence. > > > > > > > #define DRM_IOCTL_VIRTGPU_EXECBUFFER \ > > > > - DRM_IOW(DRM_COMMAND_BASE + DRM_VIRTGPU_EXECBUFFER,\ > > > > + DRM_IOWR(DRM_COMMAND_BASE + DRM_VIRTGPU_EXECBUFFER,\ > > > > struct drm_virtgpu_execbuffer) > > > > > > That changes the ioctl number and breaks the userspace api. > > > > > Have you looked at the drm_ioctl() implementation? AFAICT it > > explicitly caters for this kind of changes. > > Looking ... > > The direction bits are not used to lookup the ioctl functions, > so it should work indeed. > Nice, thanks for confirming. > Series doesn't apply to drm-misc-next and needs a rebase. > Might be nicer to address that alongside any feedback. Otherwise it'll be spamming people just for the sake of rebasing. If i find some time I'll post some comments later on today. HTH Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
