On 10/29/2018 11:24 AM, Thierry Reding wrote: > On Mon, Oct 29, 2018 at 09:02:32AM -0400, Prarit Bhargava wrote: >> A variant of this patch has been in Fedora since at least 2010 and >> AFAWCT there haven't been any complaints about the change in behavior. >> >> https://src.fedoraproject.org/cgit/rpms/kernel.git/tree/silence-fbcon-logo.patch >> >> P. >> >> ---8<--- >> >> On text-based systems the 'quiet' boot option will show printk levels >> higher than CONSOLE_LOGLEVEL_QUIET. The displaying of the Tux logo >> during boot can cause some consoles to lose display data and as a result >> confuse the end user. >> >> Do not display the Tux logo on systems that are in 'quiet' boot. >> >> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx> >> Cc: Hans de Goede <hdegoede@xxxxxxxxxx> >> Cc: Marko Myllynen <myllynen@xxxxxxxxxx> >> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> >> Cc: Kees Cook <keescook@xxxxxxxxxxxx> >> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> >> Cc: Thierry Reding <treding@xxxxxxxxxx> >> Cc: Yisheng Xie <ysxie@xxxxxxxxxxx> >> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx >> Cc: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> >> --- >> drivers/video/fbdev/core/fbcon.c | 13 ++++++++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c >> index 75ebbbf0a1fb..a2f2c7ea11ef 100644 >> --- a/drivers/video/fbdev/core/fbcon.c >> +++ b/drivers/video/fbdev/core/fbcon.c >> @@ -650,11 +650,14 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info, >> kfree(save); >> } >> >> + if (logo_shown == FBCON_LOGO_DONTSHOW) { >> + return; >> + > > You're missing a closing } here (well, you really shouldn't have the > opening { in the first place since this is a single line block. > > That's what's causing the warnings from the 0-day builder. Will send v2. P. > > Thierry > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
