Re: [PATCH] fbcon: Silence fbcon logo on 'quiet' boots

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Prarit,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sof-driver-fuweitax/master]
[also build test ERROR on v4.19 next-20181029]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Prarit-Bhargava/fbcon-Silence-fbcon-logo-on-quiet-boots/20181029-211617
base:   https://github.com/fuweitax/linux master
config: m68k-multi_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   drivers/video/fbdev/core/fbcon.c: In function 'fbcon_prepare_logo':
   drivers/video/fbdev/core/fbcon.c:680:13: error: invalid storage class for function 'set_blitting_type'
    static void set_blitting_type(struct vc_data *vc, struct fb_info *info)
                ^~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:680:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static void set_blitting_type(struct vc_data *vc, struct fb_info *info)
    ^~~~~~
   drivers/video/fbdev/core/fbcon.c:690:12: error: invalid storage class for function 'fbcon_invalid_charcount'
    static int fbcon_invalid_charcount(struct fb_info *info, unsigned charcount)
               ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:698:12: error: invalid storage class for function 'con2fb_acquire_newinfo'
    static int con2fb_acquire_newinfo(struct vc_data *vc, struct fb_info *info,
               ^~~~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:734:12: error: invalid storage class for function 'con2fb_release_oldinfo'
    static int con2fb_release_oldinfo(struct vc_data *vc, struct fb_info *oldinfo,
               ^~~~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:780:13: error: invalid storage class for function 'con2fb_init_display'
    static void con2fb_init_display(struct vc_data *vc, struct fb_info *info,
                ^~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:825:12: error: invalid storage class for function 'set_con2fb_map'
    static int set_con2fb_map(int unit, int newidx, int user)
               ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:882:12: error: invalid storage class for function 'var_to_display'
    static int var_to_display(struct display *disp,
               ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:906:13: error: invalid storage class for function 'display_to_var'
    static void display_to_var(struct fb_var_screeninfo *var,
                ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:925:20: error: invalid storage class for function 'fbcon_startup'
    static const char *fbcon_startup(void)
                       ^~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1036:13: error: invalid storage class for function 'fbcon_init'
    static void fbcon_init(struct vc_data *vc, int init)
                ^~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1183:13: error: invalid storage class for function 'fbcon_free_font'
    static void fbcon_free_font(struct display *p, bool freefont)
                ^~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1191:13: error: invalid storage class for function 'set_vc_hi_font'
    static void set_vc_hi_font(struct vc_data *vc, bool set);
                ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1193:13: error: invalid storage class for function 'fbcon_deinit'
    static void fbcon_deinit(struct vc_data *vc)
                ^~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c: In function 'fbcon_deinit':
>> drivers/video/fbdev/core/fbcon.c:1229:3: error: implicit declaration of function 'set_vc_hi_font'; did you mean 'seq_path_root'? [-Werror=implicit-function-declaration]
      set_vc_hi_font(vc, false);
      ^~~~~~~~~~~~~~
      seq_path_root
   drivers/video/fbdev/core/fbcon.c: In function 'fbcon_prepare_logo':
   drivers/video/fbdev/core/fbcon.c:1262:13: error: invalid storage class for function 'fbcon_clear'
    static void fbcon_clear(struct vc_data *vc, int sy, int sx, int height,
                ^~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1300:13: error: invalid storage class for function 'fbcon_putcs'
    static void fbcon_putcs(struct vc_data *vc, const unsigned short *s,
                ^~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1313:13: error: invalid storage class for function 'fbcon_putc'
    static void fbcon_putc(struct vc_data *vc, int c, int ypos, int xpos)
                ^~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1321:13: error: invalid storage class for function 'fbcon_clear_margins'
    static void fbcon_clear_margins(struct vc_data *vc, int bottom_only)
                ^~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1330:13: error: invalid storage class for function 'fbcon_cursor'
    static void fbcon_cursor(struct vc_data *vc, int mode)
                ^~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1365:13: error: invalid storage class for function 'fbcon_set_disp'
    static void fbcon_set_disp(struct fb_info *info, struct fb_var_screeninfo *var,
                ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1433:24: error: invalid storage class for function 'ywrap_up'
    static __inline__ void ywrap_up(struct vc_data *vc, int count)
                           ^~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1452:24: error: invalid storage class for function 'ywrap_down'
    static __inline__ void ywrap_down(struct vc_data *vc, int count)
                           ^~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1471:24: error: invalid storage class for function 'ypan_up'
    static __inline__ void ypan_up(struct vc_data *vc, int count)
                           ^~~~~~~
   drivers/video/fbdev/core/fbcon.c:1495:24: error: invalid storage class for function 'ypan_up_redraw'
    static __inline__ void ypan_up_redraw(struct vc_data *vc, int t, int count)
                           ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1519:24: error: invalid storage class for function 'ypan_down'
    static __inline__ void ypan_down(struct vc_data *vc, int count)
                           ^~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1543:24: error: invalid storage class for function 'ypan_down_redraw'
    static __inline__ void ypan_down_redraw(struct vc_data *vc, int t, int count)
                           ^~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1567:13: error: invalid storage class for function 'fbcon_redraw_softback'
    static void fbcon_redraw_softback(struct vc_data *vc, struct display *p,
                ^~~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1660:13: error: invalid storage class for function 'fbcon_redraw_move'
    static void fbcon_redraw_move(struct vc_data *vc, struct display *p,
                ^~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1694:13: error: invalid storage class for function 'fbcon_redraw_blit'
    static void fbcon_redraw_blit(struct vc_data *vc, struct fb_info *info,
                ^~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1744:13: error: invalid storage class for function 'fbcon_redraw'
    static void fbcon_redraw(struct vc_data *vc, struct display *p,
                ^~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1799:20: error: invalid storage class for function 'fbcon_softback_note'
    static inline void fbcon_softback_note(struct vc_data *vc, int t,
                       ^~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:1824:13: error: invalid storage class for function 'fbcon_scroll'
    static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
                ^~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2028:13: error: invalid storage class for function 'fbcon_bmove'
    static void fbcon_bmove(struct vc_data *vc, int sy, int sx, int dy, int dx,
                ^~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2051:13: error: invalid storage class for function 'fbcon_bmove_rec'
    static void fbcon_bmove_rec(struct vc_data *vc, struct display *p, int sy, int sx,
                ^~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2093:13: error: invalid storage class for function 'updatescrollmode'
    static void updatescrollmode(struct display *p,
                ^~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2140:12: error: invalid storage class for function 'fbcon_resize'
    static int fbcon_resize(struct vc_data *vc, unsigned int width,
               ^~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2186:12: error: invalid storage class for function 'fbcon_switch'
    static int fbcon_switch(struct vc_data *vc)
               ^~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2325:13: error: invalid storage class for function 'fbcon_generic_blank'
    static void fbcon_generic_blank(struct vc_data *vc, struct fb_info *info,
                ^~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2350:12: error: invalid storage class for function 'fbcon_blank'
    static int fbcon_blank(struct vc_data *vc, int blank, int mode_switch)
               ^~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2392:12: error: invalid storage class for function 'fbcon_debug_enter'
    static int fbcon_debug_enter(struct vc_data *vc)
               ^~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2405:12: error: invalid storage class for function 'fbcon_debug_leave'
    static int fbcon_debug_leave(struct vc_data *vc)
               ^~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2416:12: error: invalid storage class for function 'fbcon_get_font'
    static int fbcon_get_font(struct vc_data *vc, struct console_font *font)
               ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2468:13: error: invalid storage class for function 'set_vc_hi_font'
    static void set_vc_hi_font(struct vc_data *vc, bool set)
                ^~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2528:12: error: invalid storage class for function 'fbcon_do_set_font'
    static int fbcon_do_set_font(struct vc_data *vc, int w, int h,
               ^~~~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2579:12: error: invalid storage class for function 'fbcon_copy_font'
    static int fbcon_copy_font(struct vc_data *vc, int con)
               ^~~~~~~~~~~~~~~
   drivers/video/fbdev/core/fbcon.c:2601:12: error: invalid storage class for function 'fbcon_set_font'
    static int fbcon_set_font(struct vc_data *vc, struct console_font *font,
               ^~~~~~~~~~~~~~

vim +1229 drivers/video/fbdev/core/fbcon.c

e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1190  
8aac7f34 drivers/video/console/fbcon.c Takashi Iwai       2017-01-11 @1191  static void set_vc_hi_font(struct vc_data *vc, bool set);
8aac7f34 drivers/video/console/fbcon.c Takashi Iwai       2017-01-11  1192  
^1da177e drivers/video/console/fbcon.c Linus Torvalds     2005-04-16  1193  static void fbcon_deinit(struct vc_data *vc)
^1da177e drivers/video/console/fbcon.c Linus Torvalds     2005-04-16  1194  {
^1da177e drivers/video/console/fbcon.c Linus Torvalds     2005-04-16  1195  	struct display *p = &fb_display[vc->vc_num];
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1196  	struct fb_info *info;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1197  	struct fbcon_ops *ops;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1198  	int idx;
ae128786 drivers/video/console/fbcon.c Dave Airlie        2013-01-24  1199  	bool free_font = true;
^1da177e drivers/video/console/fbcon.c Linus Torvalds     2005-04-16  1200  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1201  	idx = con2fb_map[vc->vc_num];
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1202  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1203  	if (idx == -1)
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1204  		goto finished;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1205  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1206  	info = registered_fb[idx];
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1207  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1208  	if (!info)
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1209  		goto finished;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1210  
ae128786 drivers/video/console/fbcon.c Dave Airlie        2013-01-24  1211  	if (info->flags & FBINFO_MISC_FIRMWARE)
ae128786 drivers/video/console/fbcon.c Dave Airlie        2013-01-24  1212  		free_font = false;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1213  	ops = info->fbcon_par;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1214  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1215  	if (!ops)
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1216  		goto finished;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1217  
6ca8dfd7 drivers/video/console/fbcon.c Jiri Slaby         2016-06-23  1218  	if (con_is_visible(vc))
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1219  		fbcon_del_cursor_timer(info);
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1220  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1221  	ops->flags &= ~FBCON_FLAGS_INIT;
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1222  finished:
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1223  
ae128786 drivers/video/console/fbcon.c Dave Airlie        2013-01-24  1224  	fbcon_free_font(p, free_font);
e6637d54 drivers/video/console/fbcon.c Mika Kuoppala      2013-04-22  1225  	if (free_font)
e6637d54 drivers/video/console/fbcon.c Mika Kuoppala      2013-04-22  1226  		vc->vc_font.data = NULL;
ae128786 drivers/video/console/fbcon.c Dave Airlie        2013-01-24  1227  
8aac7f34 drivers/video/console/fbcon.c Takashi Iwai       2017-01-11  1228  	if (vc->vc_hi_font_mask)
8aac7f34 drivers/video/console/fbcon.c Takashi Iwai       2017-01-11 @1229  		set_vc_hi_font(vc, false);
8aac7f34 drivers/video/console/fbcon.c Takashi Iwai       2017-01-11  1230  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1231  	if (!con_is_bound(&fb_con))
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1232  		fbcon_exit();
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1233  
e614b18d drivers/video/console/fbcon.c Antonino A. Daplas 2006-06-26  1234  	return;
^1da177e drivers/video/console/fbcon.c Linus Torvalds     2005-04-16  1235  }
^1da177e drivers/video/console/fbcon.c Linus Torvalds     2005-04-16  1236  

:::::: The code at line 1229 was first introduced by commit
:::::: 8aac7f34369726d1a158788ae8aff3002d5eb528 fbcon: Fix vc attr at deinit

:::::: TO: Takashi Iwai <tiwai@xxxxxxx>
:::::: CC: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux