On Fri, 26 Oct 2018 at 11:27, Daniel Vetter <daniel@xxxxxxxx> wrote:
>
> On Fri, Oct 26, 2018 at 11:05:50AM +0100, Emil Velikov wrote:
> > From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
> >
> > Earlier commit updated the vgem driver to improve the topology, by
> > passing a platform device as parent to drm_dev_init(). Shortly
> > afterwords we updated the core function to BUG() in order to catch any
> > buggy drivers passing NULL as parent.
> >
> > While I missed the vkms driver (as the patch predates vkms by a few
> > months), the BUG caught the issue within couple of hours.
> >
> > Swap the drm_dev_init <> platform_device_register_simple order, to
> > the driver back to life.
> >
> > Fixes: f08877e79485 ("drm: BUG_ON if passing NULL parent to drm_dev_init")
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: Deepak Sharma <deepak.sharma@xxxxxxx>
> > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> > Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> > Cc: Sean Paul <sean@xxxxxxxxxx>
> > Cc: Haneen Mohammed <hamohammed.sa@xxxxxxxxx>
> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx>
> > Reported-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
> > ---
> > Rodrigo, Haneen, my plan is to push the patch to the drm-misc tree. An
> > Ack/Rb will be appreciated.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
>
Thanks, pushed via dim. Since this way breaking the 0day buildbot,
I've decided to not wait too long.
> btw just read through this stuff again, and noticed how vgem is using
> drm_gem_prime_import_dev(). I think now that your patches have landed we
> could get rid of that?
AFAICT the exynos is also using drm_gem_prime_import_dev. Having a
slightly closer look, it uses a distinct component driver for DMA.
One that varies across HW generation.
It should be doable to rework/remove that, since my knowledge in
exynos is limited, I'd refrain for now.
Thanks
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
