On Fri, Oct 26, 2018 at 01:06:47PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
>
> VGEM doesn't do anything modeset specific, so in a way exposing a
> primary node is 'wrong'. At the same time, we extensively use if for
> creating dumb buffers, fences, prime fd <> handle imports/exports.
>
> To the point that we explicitly annotate the vgem fence ioctls as
> DRM_RENDER_ALLOW and have an IGT test which opens the render node.
>
> close(drm_open_driver_render(DRIVER_VGEM))
Huh, I guess that test doesn't pass?
> Better late than never, let's flip the switch.
>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index f1f7ab9dcdbf..f1d1d9e2c82e 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -431,7 +431,8 @@ static void vgem_release(struct drm_device *dev)
> }
>
> static struct drm_driver vgem_driver = {
> - .driver_features = DRIVER_GEM | DRIVER_PRIME,
> + .driver_features = DRIVER_GEM | DRIVER_PRIME |
> + DRIVER_RENDER;
> .release = vgem_release,
> .open = vgem_open,
> .postclose = vgem_postclose,
> --
> 2.19.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
