On Tue, Oct 23, 2018 at 08:54:36AM -0400, Sean Paul wrote: > On Thu, Oct 18, 2018 at 7:11 PM Mamta Shukla <mamtashukla555@xxxxxxxxx> wrote: > > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR because its > > better to have inlined function rather than code-opened implementation. > > > > Signed-off-by: Mamta Shukla <mamtashukla555@xxxxxxxxx> > > Reviewed-by: Sean Paul <sean@xxxxxxxxxx> Applied to drm-misc-next so Julia can easily spot them all. Thanks for patch&review. -Daniel > > > --- > > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > index 6a68493..b751b76 100644 > > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > @@ -1222,10 +1222,7 @@ static int a5xx_crashdumper_init(struct msm_gpu *gpu, > > SZ_1M, MSM_BO_UNCACHED, gpu->aspace, > > &dumper->bo, &dumper->iova); > > > > - if (IS_ERR(dumper->ptr)) > > - return PTR_ERR(dumper->ptr); > > - > > - return 0; > > + return PTR_ERR_OR_ZERO(dumper->ptr); > > } > > > > static void a5xx_crashdumper_free(struct msm_gpu *gpu, > > -- > > 1.9.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
