On Thu, Oct 18, 2018 at 11:53:59PM +0200, Sam Ravnborg wrote:
> Hi Jordan.
>
> On Thu, Oct 18, 2018 at 01:58:31PM -0600, Jordan Crouse wrote:
> > Outside of superfluous parameter checks the dpu_hw_blk_init()
> > doesn't have any failure paths. Switch it over to be a void
> > function and we can remove error handling paths in all the functions
> > that call it. While we're in those functions remove unneeded
> > initialization for a static variable.
>
> I like the simplification resulting after removing the
> error handling.
>
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
> > index 200cd874b683..27699000aaca 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h
> > @@ -61,11 +61,6 @@ struct dpu_hw_lm_ops {
> > void (*setup_border_color)(struct dpu_hw_mixer *ctx,
> > struct dpu_mdss_color *color,
> > u8 border_en);
> > - /**
> > - * setup_gc : enable/disable gamma correction feature
> > - */
> > - void (*setup_gc)(struct dpu_hw_mixer *mixer,
> > - void *cfg);
> > };
> >
> > struct dpu_hw_mixer {
>
> This part looks like it do not belong in this patch.
Oops, indeed - that should have gone in the static inline patch. Thanks!
Jordan
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
