Re: [PATCH] drm: fix missing doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 17, 2018 at 02:10:31PM +0800, Chunming Zhou wrote:
> flags is new param for drm_syncob_find_fence, so need update doc, reproduce: make htmldocs
> 
> reported:
> htmldocs: drivers/gpu/drm/drm_syncobj.c:230: warning: Function parameter or member 'flags' not described in 'drm_syncobj_find_fence'
> 
> Signed-off-by: Chunming Zhou <david1.zhou@xxxxxxx>
> ---
>  drivers/gpu/drm/drm_syncobj.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index aed492570d85..b978de24f33a 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -434,10 +434,11 @@ EXPORT_SYMBOL(drm_syncobj_search_fence);
>   * @file_private: drm file private pointer
>   * @handle: sync object handle to lookup.
>   * @point: timeline point
> + * @flags: DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT or not
>   * @fence: out parameter for the fence
>   *
>   * This is just a convenience function that combines drm_syncobj_find() and
> - * drm_syncobj_lookup_fence().
> + * drm_syncobj_search_fence().

This part isn't needed yet in upstream. Can you pls resend with the patch
rebased on top of drm-misc-next?

Thanks, Daniel

>   *
>   * Returns 0 on success or a negative error value on failure. On success @fence
>   * contains a reference to the fence, which must be released by calling
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux