Re: [PATCH libdrm 2/2] gitignore: add _build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/16/18 4:26 AM, Eric Engestrom wrote:
On Monday, 2018-10-15 16:48:07 -0700, Lucas De Marchi wrote:
This is the directory used by meson/autotools (at least in the
.gitlab-ci configuration) so ignore the whole dir.

This is extremely specific to this one case; what does this change for
the gitlab ci?

In order to test locally my changes I always copy and paste the line from the CI configuration. And there we are using _build. Maybe we should be using build there and add it to gitignore? We ignore .o, .lo, .libs, .deps and build-aux dir. IMO we should ignore the whole build dir now that we build out of tree - and _build (or build) dir is the most common to use.

And it looks like I forgot one patch adding patches/ to the gitignore as well (it was what made me look into the gitignore in the first place) :-/. Same reason as why it was applied to igt for example: it's common to have a patches/ directory to maintain wip patches.

Lucas De Marchi



Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
---
  .gitignore | 1 +
  1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 49cced50..54365c7c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -24,6 +24,7 @@
  Makefile
  Makefile.in
  TAGS
+_build
  aclocal.m4
  autom4te.cache
  bsd-core/*/@
--
2.19.1.1.g8c3cf03f71

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux