> > > + if (IS_ERR(s6->supply))
> > > + return PTR_ERR(s6->supply);
> >
> > This cannot be -EPROBE_DEFER?
>
> It can and then it bails out here and retries later.
>
> I don't quite get the question, sorry.
>
> > > + if (IS_ERR(s6->reset_gpio)) {
> > > + ret = PTR_ERR(s6->reset_gpio);
> > > + if (ret != -EPROBE_DEFER)
> > > + dev_err(dev, "failed to request GPIO: %d\n", ret);
> > > + return ret;
> > > + }
> >
> > Like this..
>
> -EPROBE_DEFER is only tested to not produce error prints
> unnecessarily. In the regulator case, the regulator core already
> displays an error.
This was what I missed above (that we only check -EPROBE_DEFER to avoid printing).
So my question was just me confusing things.
Thanks for the explanation.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
