On 09/20/2018 10:22 PM, Nathan Chancellor wrote: > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. > > drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison > with extraneous parentheses [-Wparentheses-equality] > } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || > ~~~~~~~~~~~~~~~~~~~~~~~~^~~~ > drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneous > parentheses around the comparison to silence this warning > } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || > ~ ^ ~ > drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn this > equality comparison into an assignment > } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* || > ^~ > = > 1 warning generated. > > Remove the parentheses and while we're at it, clean up the commented > code, which has been here since the beginning of git history. > > Link: https://github.com/ClangBuiltLinux/linux/issues/118 > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx> Patch queued for 4.20, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
