On 10/05/2018 09:48 AM, Daniel Vetter wrote: > On Fri, Oct 05, 2018 at 08:43:51AM +0200, Daniel Vetter wrote: >> On Thu, Oct 04, 2018 at 10:40:16PM +0000, Thomas Hellstrom wrote: >>> Hi! >>> >>> I've sent out patches that replace 05/21 and 07/21. Since I'm on travel, >>> I'm not sure I'll be able to incorporate them in a pull before the merge >>> window though. >> is_implicit is taken care of with those indeed. But patch 07 seems still >> needed, at least I'm not seeing where you remove the custom page_flip >> checks. > Clarification, now that coffee kicks in: I wrote the FIXME comments since > an atomic driver should not have _any_ checks in its page_flip callback > beyond what the helper does. Only thing you can do in there is fix up uapi > inconsistency, because your driver-specific does something funky. Like in > your set_config callback, where you clear a parameter that old versions of > vmwgfx userspace don't clear. > > So end result for addressing patch 07 is that you directly put the helper > function into the vtable. You removed a bunch of checks, but there's still > a bit left. Ah, are you referring to the stdu->defined check? I think that's just a leftover sanity check that I can remove. Or were you referring to something else? /Thomas _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
