Hi, On Thu, Oct 04, 2018 at 03:43:11PM +0200, Lucas Stach wrote: > Am Donnerstag, den 04.10.2018, 14:20 +0100 schrieb Emil Velikov: > > [adding etnaviv@ for bigger exposure] > > > > Hi Guido, > > > > > On Fri, 14 Sep 2018 at 13:06, Guido Günther <agx@xxxxxxxxxxx> wrote: > > > > > > This makes it simple to test if all cache types are mappable. > > > > > > > > Signed-off-by: Guido Günther <guido.gunther@xxxxxxx> > > > --- > > > Prompted by > > > > > > https://lists.freedesktop.org/archives/etnaviv/2018-September/001946.html > > > > > > tests/etnaviv/etnaviv_bo_cache_test.c | 26 ++++++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > > > > > Patch looks spot on, sadly my etnaviv knowledge is a bit limited. > > > > Ideally one of the etna devs will double-check it, but from my POV > > > Acked-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > Nope, this test has nothing to do with the BO cache, which is a > userspace buffer cache layer, while the caching modes map to how CPU > accesses to the buffer mmap space are treated by the hardware. > > So if we want to keep this test, it needs to be split into a separate > test. After sending this I also realized that it would might be better suited for igt-gpu-tools. Would it fit in there? If so'd rework it and add it there. Cheers, -- Guido _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
