Re: vc4: NULL pointer dereference in drm_client_dev_hotplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefan and Daniel,

Am 02.10.18 um 11:48 schrieb Stefan Wahren:
> Hi Daniel,
> 
> [add Peter and Andreas]
> 
> Am 02.10.2018 um 10:44 schrieb Daniel Vetter:
>> On Mon, Oct 01, 2018 at 06:21:23PM +0200, Stefan Wahren wrote:
>>>> Sergey Suloev <ssuloev@xxxxxxxxxxxxx> hat am 1. Oktober 2018 um 12:17 geschrieben:
>>>> On 09/30/2018 10:38 PM, Stefan Wahren wrote:
>>>>>> Sergey Suloev <ssuloev@xxxxxxxxxxxxx> hat am 30. September 2018 um 15:24 geschrieben:
>>>>>>
>>>>>>
>>>>>> Here is my log
>>>>>>
>>>>>> [    2.868157] [drm:drm_setup_crtcs [drm_kms_helper]] connector 29
>>>>>> enabled? yes
>>>>>> [    2.868199] [drm:drm_setup_crtcs [drm_kms_helper]] connector 44
>>>>>> enabled? no
>>>>>> [    2.868234] [drm:drm_setup_crtcs [drm_kms_helper]] connector 50
>>>>>> enabled? yes
>>>>>> [    2.868271] [drm:drm_setup_crtcs [drm_kms_helper]] looking for
>>>>>> cmdline mode on connector 29
>>>>>> [    2.868308] [drm:drm_setup_crtcs [drm_kms_helper]] looking for
>>>>>> preferred mode on connector 29 0
>>>>>> [    2.868343] [drm:drm_setup_crtcs [drm_kms_helper]] found mode 1280x1024
>>>>>> [    2.868381] [drm:drm_setup_crtcs [drm_kms_helper]] looking for
>>>>>> cmdline mode on connector 50
>>>>>> [    2.868417] [drm:drm_setup_crtcs [drm_kms_helper]] looking for
>>>>>> preferred mode on connector 50 0
>>>>>> [    2.868465] [drm:drm_setup_crtcs [drm_kms_helper]] found mode 1920x1440
>>>>>> [    2.868500] [drm:drm_setup_crtcs [drm_kms_helper]] picking CRTCs for
>>>>>> 2048x2048 config
>>>>>> [    2.868561] [drm:drm_setup_crtcs [drm_kms_helper]] desired mode
>>>>>> 1280x1024 set on crtc 95 (0,0)
>>>>>> [    2.868673] [drm:drm_mode_object_get [drm]] OBJ ID: 29 (2)
>>>>>> [    2.868709] [drm:drm_setup_crtcs [drm_kms_helper]] desired mode
>>>>>> 1920x1440 set on crtc 74 (0,0)
>>>>>> [    2.868790] [drm:drm_mode_object_get [drm]] OBJ ID: 50 (2)
>>>>>> [    2.868832] [drm:drm_fb_helper_generic_probe [drm_kms_helper]]
>>>>>> surface width(1920), height(2880) and bpp(32)
>>>>>> [    3.001470] [drm:drm_internal_framebuffer_create [drm]] bad
>>>>>> framebuffer height 2880, should be >= 0 && <= 2048
>>>>>> [    3.001650] vc4-drm soc:gpu: [drm:drm_fb_helper_fbdev_setup
>>>>>> [drm_kms_helper]] *ERROR* Failed to set fbdev configuration
>>>>>>
>>>>> does this config work with 4.18?
>>>> I have checked with the tag v4.18 as per your request and I can confirm 
>>>> that the issue does not exists in 4.18.
>>> i tried to follow the threads mentioned by Noralf, but it seems the regression regarding CONFIG_DRM_FBDEV_OVERALLOC=200 hasn't been fixed yet.
>>>
>>> It would be nice to have this fixed in 4.19 LTS.
>> Do you need this feature?
> personally i didn't know this option before this issue, but i cannot
> speak for all the distributions. I checked Raspbian and they don't use
> this option. I had a better feeling to have at least the feedback from
> Peter and Andreas this isn't used in their distributions.

For openSUSE kernel-source.git master branch I see:

$ grep -r CONFIG_DRM_FBDEV_OVERALLOC config/
config/armv7hl/default:CONFIG_DRM_FBDEV_OVERALLOC=100
config/armv7hl/lpae:CONFIG_DRM_FBDEV_OVERALLOC=100
config/ppc64le/default:CONFIG_DRM_FBDEV_OVERALLOC=100
config/i386/pae:CONFIG_DRM_FBDEV_OVERALLOC=100
config/ppc64/default:CONFIG_DRM_FBDEV_OVERALLOC=100
config/x86_64/default:CONFIG_DRM_FBDEV_OVERALLOC=100
config/armv6hl/default:CONFIG_DRM_FBDEV_OVERALLOC=100
config/arm64/default:CONFIG_DRM_FBDEV_OVERALLOC=100

Similar to what Peter said, on the Raspberry Pi we would usually use vc4
drm; but some users have run into issues with vc4 not working with
certain monitors, so they may blacklist vc4 and use efifb instead.

Adding Alex and Petr in case more discussion is needed.

Regards,
Andreas

>>  The new generic fbdev stuff has slightly more
>> strict error checking, and the overalloc thing is somewhat of a hack to
>> support mali blobs. If this goes boom now there's a good chance it didn't
>> work beforehand either.
>> -Daniel

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux