Hi Noralf, On Mon, 2018-10-01 at 14:05 +0200, Noralf Trønnes wrote: > > Den 01.10.2018 09.56, skrev Alexey Brodkin: > > Hi Noralf, > > > > On Fri, 2018-09-28 at 12:42 +0200, Noralf Trønnes wrote: > > > Den 28.09.2018 09.34, skrev Alexey Brodkin: > > > > Hi Noralf, > > > > > > > > On Sat, 2018-09-08 at 15:46 +0200, Noralf Trønnes wrote: > > > > > The CMA helper is already using the drm_fb_helper_generic_probe part of > > > > > the generic fbdev emulation. This patch makes full use of the generic > > > > > fbdev emulation by using its drm_client callbacks. This means that > > > > > drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are > > > > > now handled by the emulation code. Additionally fbdev unregister happens > > > > > automatically on drm_dev_unregister(). > > > > > > > > > > The drm_fbdev_generic_setup() call is put after drm_dev_register() in the > > > > > driver. This is done to highlight the fact that fbdev emulation is an > > > > > internal client that makes use of the driver, it is not part of the > > > > > driver as such. If fbdev setup fails, an error is printed, but the driver > > > > > succeeds probing. > > > > > > > > > > Cc: Alexey Brodkin <abrodkin@xxxxxxxxxxxx> > > > > > Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx> > > > > > > > > Thanks for doing that! > > > > Quite some code removed from the driver and still FBDEV emulation works :) > > > > > > Yeah we're down to one line of code in the driver to get fbdev emulation > > > which is quite nice a think :D > > > > Exactly! > > > > And just to not lose this nice improvement - do I need to pull this through > > my tree or entire series will be merged in main DRM tree? > > I apply the patches to drm-misc-next when I get acks. > Unless the maintainer wants to take it himself. > So, yes I'll apply this one :-) Cool! thanks for doing that! -Alexey _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
