Re: [PATCH 05/20] drm/meson: Use drm_fbdev_generic_setup()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Noralf,

On 17/09/2018 09:53, Neil Armstrong wrote:
> Hi Noralf, Daniel,
> 
> On 14/09/2018 18:33, Noralf Trønnes wrote:
>>
>> Den 14.09.2018 10.23, skrev Neil Armstrong:
>>> Hi Daniel,
>>>
>>> On 13/09/2018 16:55, Daniel Vetter wrote:
>>>> On Thu, Sep 13, 2018 at 04:26:53PM +0200, Neil Armstrong wrote:
>>>>> Hi Daniel,
>>>>>
>>>>> On 13/09/2018 15:21, Daniel Vetter wrote:
>>>>>> On Wed, Sep 12, 2018 at 01:06:07PM +0200, Noralf Trønnes wrote:
>>>>>>> Den 12.09.2018 12.57, skrev Noralf Trønnes:
>>>>>>>> (Cc: Daniel Vetter)
>>>>>>>>
>>>>>>> Somehow that CC was dropped somewhere after leaving email client.
>>>>>>> Trying once more.
>>>>>> Yeah I just made myself unpopular. If you want SMEM_START, then you need
>>>>>> to carry a local patch now. virt_to_pfn on the vmap should work. It's
>>>>>> about 2 lines, including the change to drop HIDE_SMEM_START.
>>>>> Would it be totally unacceptable to add such 2 line :
>>>>> - enabled by a specific config depending on EXPERT and narrowed to specific platforms
>>>>> - printing a big fat pr_warning_once when used
>>>>> - with a big fat comment specifying when this code will be dropped and why we should not activate it
>>>> module_param_debug auto-taints your kernel, I'd just go with that. Plus
>>>> CONFIG_EXPERT (or CONFIG_BROKEN).
>>> OK, I think you mean module_param_unsafe, but I see the point.
>>>
>>>> But yes, I think that's something I'll happily ack. Must be acked by Dave
>>>> (and perhaps a few others too), since defacto this means we now suddenly
>>>> care about closed source blobs. I'd say get someone from amd and a few of
>>>> the driver maintainers on board with this (nouveau, Eric, Rob, Lucas,
>>>> ...), to make sure it really represents community consensus.
>>> I'll drop something, but I'm afraid a kernel won't have this hack, shouldn't this serie be delayed for a release ?
>>
>> It's not this series that drops smem_start support.
>> It happened in commit 894a677f4b3e:
>> drm/cma-helper: Use the generic fbdev emulation
>>
>> This series only deals with the fb_helper callbacks.
>>
>>> @Noaralf, do you have a branch somewhere I can base a work on ?
>>
>> I haven't got a git repo, but you can apply the patches from patchwork:
>>
>> [01/20] drm/fb-helper: Improve error reporting in setup
>> curl https://patchwork.freedesktop.org/patch/247860/mbox/ | git am
>>
>> [05/20] drm/meson: Use drm_fbdev_generic_setup()
>> curl https://patchwork.freedesktop.org/patch/247868/mbox/ | git am

Did you have time reviewing the v2 of "drm/fb_helper: Allow leaking fbdev smem_start" ?

I'll be happy acking this patch once the smem_start stuff gets sorted out.

Thanks,
Neil

[...]

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux