Re: Fwd: [PATCH v5 4/6] drm/rockchip: dw_hdmi: allow including external phys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Heiko:

Reviewed-by: zhengyang <zhengyang@xxxxxxxxxxxxxx>

Some variants of the dw-hdmi on Rockchip socs use a separate phy block
accessed via the generic phy framework, so allow them to be included
if such a phy reference is found.

Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
Tested-by: Robin Murphy <robin.murphy@xxxxxxx>
---
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index b09c3531305b..57e76dfd5f6d 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -11,6 +11,7 @@
 #include <linux/mfd/syscon.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/phy/phy.h>
 #include <linux/regmap.h>
  #include <drm/drm_of.h>
@@ -49,6 +50,7 @@ struct rockchip_hdmi {
     struct clk *vpll_clk;
     struct clk *grf_clk;
     struct dw_hdmi *hdmi;
+    struct phy *phy;
 };
  #define to_rockchip_hdmi(x)    container_of(x, struct rockchip_hdmi, x)
@@ -376,6 +378,14 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
         return ret;
     }
 +    hdmi->phy = devm_phy_optional_get(dev, "hdmi");
+    if (IS_ERR(hdmi->phy)) {
+        ret = PTR_ERR(hdmi->phy);
+        if (ret != -EPROBE_DEFER)
+            DRM_DEV_ERROR(hdmi->dev, "failed to get phy\n");
+        return ret;
+    }
+
     drm_encoder_helper_add(encoder, &dw_hdmi_rockchip_encoder_helper_funcs);
     drm_encoder_init(drm, encoder, &dw_hdmi_rockchip_encoder_funcs,
              DRM_MODE_ENCODER_TMDS, NULL);


_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux