Re: [PATCH libdrm v2 00/13] hide library symbols by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14 September 2018 at 00:57, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote:
> Rely on -fvisibility=hidden to hide the symbols. Previous version of
> this series applying only to drm_intel.so is
>
>         Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxx>
>
> but it's not included here since I changed the approach for the build
> system change.
>
> drm_private can also be removed from other symbols but it proved to be
> a lot of manual work to re-align all the fields, so I decided to leave
> it to be done on top as a cleanup.
>
Did you read through the reasoning behind
0f8da82500ec542e269092c0718479e25eaff5f6?

Alternatively you do not care too much about compat in said cases,
which is fine.
My only request is - keep it only for the Intel bits.

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux