Re: [PATCH] [RFC]drm: add syncobj timeline support v5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 19.09.2018 um 05:20 schrieb zhoucm1:



On 2018年09月18日 16:32, Christian König wrote:
+    for (i = 0; i < args->count_handles; i++) {
+        if (syncobjs[i]->type == DRM_SYNCOBJ_TYPE_TIMELINE) {
+            DRM_ERROR("timeline syncobj cannot reset!\n");

Why not? I mean that should still work or do I miss anything?
timeline semaphore spec doesn't require reset interface, it says the timeline value only can be changed by signal operations.

Yeah, but we don't care about the timeline spec in the kernel.

Question is rather if that still makes sense to support that and as far as I can see it should be trivial to reinitialize the object.
Hi Daniel Rakos,

Could you give a comment on this question? Is it necessary to support timeline reset interface?  I only see the timeline value can be changed by signal operations in Spec.

I think the Vulkan spec is rather irrelevant here. We added the reset operation because of drivers which wanted to re-use an existing syncobj.

That is still a valid use case even when Vulkan doesn't have an interface for it.

Christian.



Thanks,
David Zhou


_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux