Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Sep 17, 2018 at 08:27:18AM +0000, Lisovskiy, Stanislav wrote:
> On Fri, 2018-09-14 at 14:59 +0000, Alexandru-Cosmin Gheorghe wrote:
> > On Fri, Sep 14, 2018 at 02:49:09PM +0000, Lisovskiy, Stanislav wrote:
> > > On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani wrote:
> > > > Hi, 
> > > > 
> > > > > -----Original Message-----
> > > > > From: Intel-gfx [mailto:intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx
> > > > > ] On
> > > > > Behalf
> > > > > Of Lisovskiy, Stanislav
> > > > > Sent: perjantai 14. syyskuuta 2018 17.31
> > > > > To: ville.syrjala@xxxxxxxxxxxxxxx
> > > > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Syrjala, Ville
> > > > > <ville.syrjala@
> > > > > intel.com>;
> > > > > Heikkila, Juha-pekka <juha-pekka.heikkila@xxxxxxxxx>; dri-
> > > > > devel@xxxxxxxxxxxxxxxxxxxxx; Peres, Martin <martin.peres@intel.
> > > > > com>
> > > > > Subject: Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format
> > > > > support
> > > > > 
> > > > > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > > > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy,
> > > > > > Stanislav
> > > > > > wrote:
> > > > > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy
> > > > > > > wrote:
> > > > > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > > > > added
> > > > > > > > support for it to i915(SkyLake+).
> > > > > > > > 
> > > > > > > > Stanislav Lisovskiy (2):
> > > > > > > >   drm: Introduce new DRM_FORMAT_XYUV
> > > > > > > >   drm/i915: Adding YUV444 packed format support for skl+
> > > > > > > > 
> > > > > > > >  drivers/gpu/drm/drm_fourcc.c         |  1 +
> > > > > > > >  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
> > > > > > > >  drivers/gpu/drm/i915/intel_display.c | 15
> > > > > > > > +++++++++++++++
> > > > > > > > drivers/gpu/drm/i915/intel_sprite.c  |  2 ++
> > > > > > > >  include/uapi/drm/drm_fourcc.h        |  1 +
> > > > > > > >  5 files changed, 20 insertions(+), 1 deletion(-)
> > > > > > > > 
> > > > > > > 
> > > > > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > > > > This one left in order to get XYUV support.
> > > > > > 
> > > > > > Did we figure out userspace for this?
> > > > > > 
> > > > > > Was the conflict solved with the other guy (forgot who it is)
> > > > > > trying
> > > > > > to add the same format with a different name?
> > > > > 
> > > > > Currently for userspace we have VLC(checked with Juha-Pekka)
> > > > > and
> > > > > also IGT
> > > > > test case.
> > > > > 
> > > > > I think those guys were from ARM and they were adding also
> > > > > support
> > > > > for
> > > > > XYUV. The only difference was that they called XYUV, like
> > > > > XYUV8888
> > > > > something.
> > > > > Our patches were otherwise identical regarding drm_fourcc.c
> > > > > part, I
> > > > > don't
> > > > > see their stuff merged, but I guess it really shouldn't matter,
> > > > > who
> > > > > does this
> > > > > first. i915 specific part doesn't conflict with their stuff. To
> > > > > be
> > > > > honest, I forgot
> > > > > the guy's name neither could find his email in my mailbox.
> > > > > So hopefully somebody shows up here.
> > > > 
> > > > Stan:
> > > > Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@xxxxxxx> ? 
> > > > 
> > > 
> > > Exactly, found now. Thanks for the hint! 
> > 
> > Yes, that's me.
> > Not a real conflict here, as long as your patches are ready to be
> > merged feel free to do it and I will just rebase my series on top of
> > that.
> 
> I can change DRM_FORMAT_XYUV naming to DRM_FORMAT_XYUV8888 also, so
> that my patch series then is compatible with yours.

That would be nice.
Thank you.

> 
> > 
> > 
> > > 
> > > > > 
> > > > > > 
> > > > > 
> > > > > --
> > > > > Best Regards,
> > > > > 
> > > > > Lisovskiy Stanislav
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > 
> > > -- 
> > > Best Regards,
> > > 
> > > Lisovskiy Stanislav
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > 
> > 
> -- 
> Best Regards,
> 
> Lisovskiy Stanislav

-- 
Cheers,
Alex G
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux