RE: [PATCH] drm/exynos: exynos_drm.h header file fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Kamil.
Sorry for being late.

Below is my comments.

> -----Original Message-----
> From: Kamil Debski [mailto:k.debski@xxxxxxxxxxx]
> Sent: Saturday, February 11, 2012 2:32 AM
> To: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: kyungmin.park@xxxxxxxxxxx; inki.dae@xxxxxxxxxxx;
> jy0922.shim@xxxxxxxxxxx; sw0312.kim@xxxxxxxxxxx; airlied@xxxxxxxx; Kamil
> Debski
> Subject: [PATCH] drm/exynos: exynos_drm.h header file fixes
> 
> First of all #ifdef __KERNEL__ was added to exynos_drm.h to
> mark the part that should be left out of userspace.
> Secondly exynos_drm.h was added to include/drm/Kbuild, so it
> will be included when doing make headers_install.
> 
> Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  include/drm/Kbuild       |    1 +
>  include/drm/exynos_drm.h |    5 +++--
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/include/drm/Kbuild b/include/drm/Kbuild
> index a5c0e10..1e38a19 100644
> --- a/include/drm/Kbuild
> +++ b/include/drm/Kbuild
> @@ -2,6 +2,7 @@ header-y += drm.h
>  header-y += drm_fourcc.h
>  header-y += drm_mode.h
>  header-y += drm_sarea.h
> +header-y += exynos_drm.h
>  header-y += i810_drm.h
>  header-y += i915_drm.h
>  header-y += mga_drm.h
> diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h
> index 13b8660..5900e0b 100644
> --- a/include/drm/exynos_drm.h
> +++ b/include/drm/exynos_drm.h
> @@ -99,6 +99,7 @@ struct drm_exynos_plane_set_zpos {
>  #define DRM_IOCTL_EXYNOS_PLANE_SET_ZPOS	DRM_IOWR(DRM_COMMAND_BASE +
> \
>  		DRM_EXYNOS_PLANE_SET_ZPOS, struct drm_exynos_plane_set_zpos)
> 
> +#ifdef __KERNEL__

could you please modify it for this macro to be place above of struct
exynos_drm_panel_info? struct exynos_drm_panel_info also isn't needed for
user side.

Thanks.

>  /**
>   * Platform Specific Structure for DRM based FIMD.
>   *
> @@ -140,5 +141,5 @@ struct exynos_drm_hdmi_pdata {
>  	unsigned int			default_win;
>  	unsigned int			bpp;
>  };
> -
> -#endif
> +#endif /* __KERNEL__ */
> +#endif /* _EXYNOS_DRM_H_ */
> --
> 1.7.0.4

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux