Hi Laurent, On 14/09/18 12:17, Laurent Pinchart wrote: > Hi Kieran, > > On Friday, 31 August 2018 21:12:58 EEST Kieran Bingham wrote: >> From: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx> >> >> This patch supports pixel format of RGB332, ARGB4444, XRGB4444, >> BGR888, RGB888, BGRA8888, BGRX8888 and YVYU. >> VYUY pixel format is not supported by H/W specification. > > Should VYUY be removed from rcar_du_vsp.c ? This can be done in a separate > patch. On further consideration - yes, I believe it should. Removal patch generated, and doesn't negatively affect the current kms-tests, so expect it in your inbox imminently. -- Regards Kieran > >> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> >> --- >> >> This patch does not remove existing support for multiplanar YVUY, even >> though the hardware does not explicitly provide it, because we support >> it through software by swapping the plane buffers. >> >> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 32 +++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c >> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 7c7aff8cdf77..d1bd174ec893 >> 100644 >> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c >> @@ -124,6 +124,38 @@ static const struct rcar_du_format_info >> rcar_du_format_infos[] = { .fourcc = DRM_FORMAT_YVU444, >> .bpp = 24, >> .planes = 3, >> + }, { >> + .fourcc = DRM_FORMAT_RGB332, >> + .bpp = 8, >> + .planes = 1, >> + }, { >> + .fourcc = DRM_FORMAT_ARGB4444, >> + .bpp = 16, >> + .planes = 1, >> + }, { >> + .fourcc = DRM_FORMAT_XRGB4444, >> + .bpp = 16, >> + .planes = 1, >> + }, { >> + .fourcc = DRM_FORMAT_BGR888, >> + .bpp = 24, >> + .planes = 1, >> + }, { >> + .fourcc = DRM_FORMAT_RGB888, >> + .bpp = 24, >> + .planes = 1, >> + }, { >> + .fourcc = DRM_FORMAT_BGRA8888, >> + .bpp = 32, >> + .planes = 1, >> + }, { >> + .fourcc = DRM_FORMAT_BGRX8888, >> + .bpp = 32, >> + .planes = 1, >> + }, { >> + .fourcc = DRM_FORMAT_YVYU, >> + .bpp = 16, >> + .planes = 1, >> }, >> }; > > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel