Hi Hans, I'll pick it up in due course. Thanks. On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrote: > Russell (or someone else), can you Ack this patch? I'd like to get this > for 4.20. > > Thanks! > > Hans > > On 08/27/2018 02:28 PM, Hans Verkuil wrote: > > The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to > > prevent the CEC framework from retrying the transmit. If the > > transmit was successful, then don't set this flag. > > > > Found by running 'cec-compliance -A' on a beaglebone box. > > > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > --- > > drivers/gpu/drm/i2c/tda9950.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c > > index 5d2f0d548469..4a14fc3b5011 100644 > > --- a/drivers/gpu/drm/i2c/tda9950.c > > +++ b/drivers/gpu/drm/i2c/tda9950.c > > @@ -191,7 +191,8 @@ static irqreturn_t tda9950_irq(int irq, void *data) > > break; > > } > > /* TDA9950 executes all retries for us */ > > - tx_status |= CEC_TX_STATUS_MAX_RETRIES; > > + if (tx_status != CEC_TX_STATUS_OK) > > + tx_status |= CEC_TX_STATUS_MAX_RETRIES; > > cec_transmit_done(priv->adap, tx_status, arb_lost_cnt, > > nack_cnt, 0, err_cnt); > > break; > > > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
