Now that the Host1x bus_type implements a .dma_configure callback, subdevices should automatically get configured for DMA as their drivers bind, so there's no need to also force it at device creation time. CC: Thierry Reding <thierry.reding@xxxxxxxxx> CC: Mikko Perttunen <cyndis@xxxxxxxx> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx> --- I *believe* my reasoning is correct here, but please shout if it's not. drivers/gpu/host1x/bus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index 815bdb42e3f0..24f60e34cdf1 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -421,8 +421,6 @@ static int host1x_device_add(struct host1x *host1x, device->dev.bus = &host1x_bus_type; device->dev.parent = host1x->dev; - of_dma_configure(&device->dev, host1x->dev->of_node, true); - err = host1x_device_parse_dt(device, driver); if (err < 0) { kfree(device); -- 2.19.0.dirty _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel