Quoting Emil Velikov (2018-09-06 16:14:07) > From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > They're used internally and never meant to be part of the API. > Add the drm_private notation, which should resolve that. > > Cc: Eric Engestrom <eric.engestrom@xxxxxxxxx> > Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Fixes: 4e81d4f9c9b ("intel: add generic functions to check PCI ID") > Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > --- > intel/intel_chipset.c | 4 ++-- > intel/intel_chipset.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c > index d5c33cc5..5aa4a2f2 100644 > --- a/intel/intel_chipset.c > +++ b/intel/intel_chipset.c > @@ -44,7 +44,7 @@ static const struct pci_device { > INTEL_SKL_IDS(9), > }; > > -bool intel_is_genx(unsigned int devid, int gen) > +drm_private bool intel_is_genx(unsigned int devid, int gen) > { > const struct pci_device *p, > *pend = pciids + sizeof(pciids) / sizeof(pciids[0]); > @@ -66,7 +66,7 @@ bool intel_is_genx(unsigned int devid, int gen) > return false; > } > > -bool intel_get_genx(unsigned int devid, int *gen) > +drm_private bool intel_get_genx(unsigned int devid, int *gen) We should only need to put the attribute in the header, right? -Chris _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel