HI all, On 6 September 2018 at 07:10, Lucas De Marchi <lucas.de.marchi@xxxxxxxxx> wrote: > On Wed, Sep 5, 2018 at 7:00 PM Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: >> >> well.... it builds for me. >> >> but any idea what might be wrong here on gitlab ci? > FWIW gitlab gives you the test target and command used. It might be a bit hard to find at first though :-\ FAILED: meson-test /usr/bin/python3 /usr/local/bin/meson test --no-rebuild --print-errorlogs > From the logs: > > The output from the failed tests: > > 8/21 intel-symbol-check FAIL 0.29 s (exit status 1) > > --- command --- > NM='/usr/sbin/nm' /usr/sbin/bash > /builds/mesa/drm/_build/../intel/intel-symbol-check > intel/libdrm_intel.so.1.0.0 > --- stdout --- > intel_get_genx intel_is_genx > ------- > > So... it's not the build that fails, the test is checking for exported > symbols, and it only does that when using meson (actually as part of > the tests). And we don't use -fvisibility=hidden?!??! Ugh, I think we > need some fixing on that :( > I nuked it back in 0f8da82500ec542e269092c0718479e25eaff5f6 because weird compilers. I guess we can reconsider that? On the other hand: git grep does point out to drm_private. Will send a patch in a moment, unless someone beats me to it. -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
