[PATCH libdrm 2/2] *-symbols-check: error out when using unset variables

[Emil Velikov <emil.l.velikov@xxxxxxxxx>]

From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>

It will make bugs like the one fixed with previous patch dead obvious.

Cc: Eric Engestrom <eric.engestrom@xxxxxxxxx>
Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
---
 amdgpu/amdgpu-symbol-check       | 2 ++
 etnaviv/etnaviv-symbol-check     | 2 ++
 exynos/exynos-symbol-check       | 2 ++
 freedreno/freedreno-symbol-check | 2 ++
 intel/intel-symbol-check         | 2 ++
 libkms/kms-symbol-check          | 2 ++
 nouveau/nouveau-symbol-check     | 2 ++
 omap/omap-symbol-check           | 2 ++
 radeon/radeon-symbol-check       | 2 ++
 tegra/tegra-symbol-check         | 2 ++
 10 files changed, 20 insertions(+)

diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
index 90b7a1d6..07477243 100755
--- a/amdgpu/amdgpu-symbol-check
+++ b/amdgpu/amdgpu-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.am/libdrm_amdgpuinclude_HEADERS
 
diff --git a/etnaviv/etnaviv-symbol-check b/etnaviv/etnaviv-symbol-check
index bc509615..18910688 100755
--- a/etnaviv/etnaviv-symbol-check
+++ b/etnaviv/etnaviv-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.sources/LIBDRM_ETNAVIV_H_FILES
 
diff --git a/exynos/exynos-symbol-check b/exynos/exynos-symbol-check
index e9f1b04d..49d611e6 100755
--- a/exynos/exynos-symbol-check
+++ b/exynos/exynos-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.am/libdrm_exynos*_HEADERS
 
diff --git a/freedreno/freedreno-symbol-check b/freedreno/freedreno-symbol-check
index e732c995..6da9d667 100755
--- a/freedreno/freedreno-symbol-check
+++ b/freedreno/freedreno-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.sources/LIBDRM_FREEDRENO_H_FILES
 
diff --git a/intel/intel-symbol-check b/intel/intel-symbol-check
index 4d30a4b1..de377bef 100755
--- a/intel/intel-symbol-check
+++ b/intel/intel-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.sources/LIBDRM_INTEL_H_FILES
 
diff --git a/libkms/kms-symbol-check b/libkms/kms-symbol-check
index a5c2120d..30f444f7 100755
--- a/libkms/kms-symbol-check
+++ b/libkms/kms-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.sources/LIBKMS_H_FILES
 
diff --git a/nouveau/nouveau-symbol-check b/nouveau/nouveau-symbol-check
index b3a24101..6296244c 100755
--- a/nouveau/nouveau-symbol-check
+++ b/nouveau/nouveau-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.sources/LIBDRM_NOUVEAU_H_FILES
 
diff --git a/omap/omap-symbol-check b/omap/omap-symbol-check
index 0fb4a0f2..16da3c40 100755
--- a/omap/omap-symbol-check
+++ b/omap/omap-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.am/libdrm_omap*HEADERS
 
diff --git a/radeon/radeon-symbol-check b/radeon/radeon-symbol-check
index 7d79d901..da605bb8 100755
--- a/radeon/radeon-symbol-check
+++ b/radeon/radeon-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first five) are taken from the public headers.
 # A list of the latter should be available Makefile.sources/LIBDRM_RADEON_H_FILES
 
diff --git a/tegra/tegra-symbol-check b/tegra/tegra-symbol-check
index 509b678c..8539b95b 100755
--- a/tegra/tegra-symbol-check
+++ b/tegra/tegra-symbol-check
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -u
+
 # The following symbols (past the first nine) are taken from tegra.h.
 
 FUNCS=$($NM -D --format=bsd --defined-only ${1-.libs/libdrm_tegra.so} | awk '{print $3}'| while read func; do
-- 
2.18.0

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel