Hi Bjorn and Linus
Thanks for the comments.
Based on this, since we want to remove the dev/phone dependency but
retain the driver + panel dependency on the compatible string, while
addressing Philip's comments, I shall rename the string as
"truly,nt35597-2K-display".
Let me know if there are any concerns with this.
Thanks
Abhinav
On 2018-09-03 15:00, Linus Walleij wrote:
On Mon, Sep 3, 2018 at 9:50 PM Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:
On Tue 28 Aug 15:39 PDT 2018, Abhinav Kumar wrote:
> From: "abhinavk@xxxxxxxxxxxxxx" <abhinavk@xxxxxxxxxxxxxx>
>
> Add support for Truly NT35597 panel driver used
> in MSM reference platforms.
>
> This panel driver supports both single DSI and dual DSI
> modes.
>
> However, this patch series adds support only for
> dual DSI mode.
>
> Changes in v6:
> - Introduce panel config to store panel specific
> details
> - Bring back the size member for the panel command
> structure to make the design more scalable
> - Move the display mode from the DT to driver
> - Change the compatible string to indicate which
> which board and panel it will be used for
> - Rename the functions to match the panel driver
> - Have a data member for each compatible string
> - Remove the panel commands split as its not
> required for the panel init functionality
>
> Signed-off-by: Archit Taneja <architt@xxxxxxxxxxxxxx>
> Signed-off-by: Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx>
[..]
> diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
[..]
> + { .compatible = "qcom,sdm845-mtp-2K-display",
I do not agree with Linus here.
If I understand correctly the variability in the video timing comes
from
the fact that the LCD Driver IC (NT35597) can be paired with different
LCD panels. As such I strongly believe that the compatible should
describe this combo, not which phone/devkit you mounted a panel using
this Driver IC on.
I agree with that.
I just saw "it's some qualcomm string, not just the name of the LCD
driver so OK".
The inability to parse the "qcom,*" string is just my ignorance, sorry
for that.
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
